fix: Add packages to i18n devDependencies#170
Merged
Conversation
Signed-off-by: lornakelly <lornakelly88@gmail.com>
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds React runtime packages to the i18n workspace package so it can compile/typecheck against React and ReactDOM.
Changes:
- Add
reactandreact-domentries topackages/i18n/package.json.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fantonangeli
approved these changes
Jun 8, 2026
cheryl7114
approved these changes
Jun 8, 2026
Contributor
Author
|
@ricardozanini Please merge when you have a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #169
Summary
Add
reactandreact-domasdevDependenciesin i18npackage.jsonto keep consistent with pnpm catalog (same as theserverless-workflow-diagram-editorpackage).Peer dependencies are not installed for the package's dev/build/test cycle so it was resolving react packages to a stale version of react in lock file, not the newly bumped version in original dependabot PR. This resulted in original PR failing due to a duplicate dependency in the lock file. This fix is to prevent this from happening in the future when react packages are bumped again by declaring it as a dev dependency which gives it a catalog-pinned copy of teh React packages